Generate the en_US.UTF-8 locale in the docker image #84
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issues when working with utf-8 text from the command line
kylecarbs
requested review from
nhooyr
and removed request for
kylecarbs and
code-asher
nhooyr
suggested changes
Mar 7, 2019
| @@ -19,6 +19,8 @@ FROM ubuntu:18.10 | |||
| RUN apt-get update | |||
| RUN apt-get install -y openssl | |||
| RUN apt-get install -y net-tools | |||
| RUN apt-get install -y locales | |||
| RUN locale-gen en_US.UTF-8 | |||
There was a problem hiding this comment.
You'll also need
# We unfortunately cannot use update-locale because docker will not use the env variables
# configured in /etc/default/locale so we need to set it manually.
ENV LANG=en_US.UTF-8
|
If you don't mind, I'll take this over to get this out quicker. Will credit you in my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues when working with utf-8 text from the command line
close #83